-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Change span statuses for gRPC server spans #3333
BREAKING: Change span statuses for gRPC server spans #3333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with one minor comment remaining.
@tigrannajaryan Any opinion on getting this merged for the upcoming April Release? |
I think we can merge. |
@pellared can you resolve the conflicts? |
@tigrannajaryan @carlosalberto Done. The PR is ready to be merged 😉 |
Fixes #3110
Changes
The idea behind the PR is to make the spam statuses gRPC convention similar to HTTP semantic conventions.
The gRPC statuses -> HTTP status codes mapping is not anywhere strictly defined.
However, there is are some approximations which can be found:
I got confused if we should treat
INTERNAL
asError
forSpanKind.SERVER
because of:On the other hand, the description of
INTERNAL
says:Therefore, I decided to leave it as
Error
. Also because this is backwards compatible (at least for this gRPC status).